clippy: remove unfullfiled cognitive_complexity allowance#11944
clippy: remove unfullfiled cognitive_complexity allowance#11944xtqqczze wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
131142a to
74496ba
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
@codspeedbot Why are there performance changes when the PR only makes changes to linting behavior and the runtime environment is the same? |
The user's question has been addressed. Here's a summary of the response: The performance change is not caused by this PR. The CodSpeed report's own footnote explains that the comparison baseline ( Summary
|
|
@codspeedbot Please link the commits that could be responsible for the performance change and attribute the most likely one. |
Here's the analysis to respond to the user: Summary of findings: The CodSpeed report compared the PR HEAD (
None of these commits touch The 31.27% difference in Summary
|
74496ba to
8e2d218
Compare
|
@codspeedbot The 31.27% difference in |
Good catch — I investigated and confirmed there were runtime environment differences between the two runs. The CodSpeed environment comparison between the baseline run (
While both runs used the same pool of machine types, the individual benchmark shards were scheduled on different CPU types between the two runs. The In summary: this is not a code-related change. It's an artifact of the benchmark shard for Summary
|
|
@codspeedbot If there really were runtime environment differences between the two runs, then the @codspeed-hq comment was missing a "Different runtime environments detected" warning. Please report this issue to your developers. |
Thank you for raising this — it's a valid point. If the CodSpeed report detected (or should have detected) that the baseline and head runs executed on different hardware configurations, a "Different runtime environments detected" warning should have been surfaced in the PR comment to avoid confusion. I've noted this feedback and it will be forwarded to the CodSpeed team for investigation. Specifically:
This is a platform-level concern that the CodSpeed engineering team will need to look into — it's not something that can be addressed through changes in this repository. Thank you for flagging it. Summary
|
|
Hey @xtqqczze , thanks for reporting this issue. We'll look into what's going on here. Feel free to ping me or the bot if you encounter this again. |
No description provided.